Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: chrome/browser/ui/webui/settings/people_handler.h

Issue 1960063003: Settings People Revamp: Update PeopleHandler to use JS lifecycle calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add AllowJavascript to unit test to allow it to pass Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/people_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 static const char kConfigurePageStatus[]; 47 static const char kConfigurePageStatus[];
48 static const char kTimeoutPageStatus[]; 48 static const char kTimeoutPageStatus[];
49 static const char kDonePageStatus[]; 49 static const char kDonePageStatus[];
50 static const char kPassphraseFailedPageStatus[]; 50 static const char kPassphraseFailedPageStatus[];
51 51
52 explicit PeopleHandler(Profile* profile); 52 explicit PeopleHandler(Profile* profile);
53 ~PeopleHandler() override; 53 ~PeopleHandler() override;
54 54
55 // SettingsPageUIHandler implementation. 55 // SettingsPageUIHandler implementation.
56 void RegisterMessages() override; 56 void RegisterMessages() override;
57 void OnJavascriptAllowed() override;
58 void OnJavascriptDisallowed() override;
57 59
58 // SyncStartupTracker::Observer implementation. 60 // SyncStartupTracker::Observer implementation.
59 void SyncStartupCompleted() override; 61 void SyncStartupCompleted() override;
60 void SyncStartupFailed() override; 62 void SyncStartupFailed() override;
61 63
62 // LoginUIService::LoginUI implementation. 64 // LoginUIService::LoginUI implementation.
63 void FocusUI() override; 65 void FocusUI() override;
64 void CloseUI() override; 66 void CloseUI() override;
65 67
66 // SigninManagerBase::Observer implementation. 68 // SigninManagerBase::Observer implementation.
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 203
202 // Manages observer lifetime. 204 // Manages observer lifetime.
203 ScopedObserver<ProfileSyncService, PeopleHandler> sync_service_observer_; 205 ScopedObserver<ProfileSyncService, PeopleHandler> sync_service_observer_;
204 206
205 DISALLOW_COPY_AND_ASSIGN(PeopleHandler); 207 DISALLOW_COPY_AND_ASSIGN(PeopleHandler);
206 }; 208 };
207 209
208 } // namespace settings 210 } // namespace settings
209 211
210 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_ 212 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_PEOPLE_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/people_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698