chrome/browser/ui/webui/settings/people_handler.h - Issue 1960063003: Settings People Revamp: Update PeopleHandler to use JS lifecycle calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/people_handler.h

Issue 1960063003: Settings People Revamp: Update PeopleHandler to use JS lifecycle calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add AllowJavascript to unit test to allow it to pass Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/settings/people_handler.h

diff --git a/chrome/browser/ui/webui/settings/people_handler.h b/chrome/browser/ui/webui/settings/people_handler.h

index edf70f2ad4fd3b22f01b92963f6f7cbe4c615d4d..b47f8cc0090f85170b4730b2c9664b86362af734 100644

--- a/chrome/browser/ui/webui/settings/people_handler.h

+++ b/chrome/browser/ui/webui/settings/people_handler.h

@@ -54,6 +54,8 @@ class PeopleHandler : public SettingsPageUIHandler,

// SettingsPageUIHandler implementation.

void RegisterMessages() override;

+ void OnJavascriptAllowed() override;

+ void OnJavascriptDisallowed() override;

// SyncStartupTracker::Observer implementation.

void SyncStartupCompleted() override;

« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/people_handler.cc » ('j') | no next file with comments »