chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc

diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc b/chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc

index dd1f14be412596116562e607876512d9893ee847..549e6cd0fca1a1a035cbf6c0c8199da81192896c 100644

--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc

+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc

@@ -52,8 +52,7 @@ certificate_provider::CertificateInfo CreateCertInfo(

certificate_provider::CertificateInfo cert_info;

cert_info.certificate =

net::ImportCertFromFile(net::GetTestCertsDirectory(), cert_filename);

- EXPECT_NE(nullptr, cert_info.certificate) << "Could not load "

- << cert_filename;

+ EXPECT_TRUE(cert_info.certificate) << "Could not load " << cert_filename;

cert_info.type = net::SSLPrivateKey::Type::RSA;

cert_info.supported_hashes.push_back(net::SSLPrivateKey::Hash::SHA256);

cert_info.max_signature_length_in_bytes = 123;

« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »