chrome/browser/banners/app_banner_manager.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/trees/layer_tree_host_unittest_serialization.cc ('k') | chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_manager.cc

diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc

index d2b697fa9c7c18d71ec6dbeef2f2d4848f0bc0eb..e20ec795e24a02780581ddb694caf39cd9ede993 100644

--- a/chrome/browser/banners/app_banner_manager.cc

+++ b/chrome/browser/banners/app_banner_manager.cc

@@ -60,7 +60,7 @@ void AppBannerManager::ReplaceWebContents(content::WebContents* web_contents) {

}

bool AppBannerManager::IsFetcherActive() {

- return data_fetcher_ != nullptr && data_fetcher_->is_active();

+ return data_fetcher_ && data_fetcher_->is_active();

}

void AppBannerManager::DidNavigateMainFrame(

@@ -116,7 +116,7 @@ bool AppBannerManager::HandleNonWebApp(const std::string& platform,

}

void AppBannerManager::CancelActiveFetcher() {

- if (data_fetcher_ != nullptr) {

+ if (data_fetcher_) {

data_fetcher_->Cancel();

data_fetcher_ = nullptr;

}