chrome/browser/themes/theme_service.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_service.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc ('k') | chrome/browser/ui/views/certificate_selector_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/theme_service.cc

diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc

index 11e8f1767a9b9aa2ed06f5019d260690fb9e900e..88081094f2f37c0b7fac1eb1531b892adcdf3132 100644

--- a/chrome/browser/themes/theme_service.cc

+++ b/chrome/browser/themes/theme_service.cc

@@ -568,7 +568,8 @@ void ThemeService::LoadThemePrefs() {

? chrome::kThemePackMaterialDesignFilename

: chrome::kThemePackFilename);

SwapThemeSupplier(BrowserThemePack::BuildFromDataPack(path, current_id));

- loaded_pack = theme_supplier_ != nullptr;

+ if (theme_supplier_)

+ loaded_pack = true;

}

if (loaded_pack) {