Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1958563002: Do not use LayoutProgress for a UA shadow element of a PROGRESS element. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use LayoutProgress for a UA shadow element of a PROGRESS element. The old behavior was the first child element of PROGRESS UA ShadowRoot used LayoutProgress if the PROGRESS has -webkit-appearance:none. However, LayoutProgress does nothing if its associated element has no appearance. So the behavior made no sense. This CL has no behavior changes. BUG=609687 Committed: https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0 Cr-Commit-Position: refs/heads/master@{#392023}

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
tkent
kochi@, would you review this please?
4 years, 7 months ago (2016-05-06 07:23:38 UTC) #3
kochi
lgtm
4 years, 7 months ago (2016-05-06 08:13:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958563002/1
4 years, 7 months ago (2016-05-06 08:25:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 08:29:34 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 08:31:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0
Cr-Commit-Position: refs/heads/master@{#392023}

Powered by Google App Engine
This is Rietveld 408576698