third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp - Issue 1958563002: Do not use LayoutProgress for a UA shadow element of a PROGRESS element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp

Issue 1958563002: Do not use LayoutProgress for a UA shadow element of a PROGRESS element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.h ('k') | third_party/WebKit/Source/core/layout/LayoutProgress.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp b/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp

index 2f09229e13480fc32f186aaea93e5693cd845aea..4ee7485ae7563ae50a60e0b7ecfea3de86c0d808 100644

--- a/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp

@@ -32,7 +32,7 @@

#include "core/HTMLNames.h"

#include "core/html/HTMLProgressElement.h"

-#include "core/layout/LayoutProgress.h"

+#include "core/layout/LayoutObject.h"

namespace blink {

@@ -61,11 +61,6 @@ inline ProgressInnerElement::ProgressInnerElement(Document& document)

DEFINE_NODE_FACTORY(ProgressInnerElement)

-LayoutObject* ProgressInnerElement::createLayoutObject(const ComputedStyle&)

- return new LayoutProgress(this);

bool ProgressInnerElement::layoutObjectIsNeeded(const ComputedStyle& style)

{

if (progressElement()->openShadowRoot())