Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutProgress.cpp

Issue 1958563002: Do not use LayoutProgress for a UA shadow element of a PROGRESS element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutProgress.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 * 18 *
19 */ 19 */
20 20
21 #include "core/layout/LayoutProgress.h" 21 #include "core/layout/LayoutProgress.h"
22 22
23 #include "core/html/HTMLProgressElement.h" 23 #include "core/html/HTMLProgressElement.h"
24 #include "core/layout/LayoutTheme.h" 24 #include "core/layout/LayoutTheme.h"
25 #include "wtf/CurrentTime.h" 25 #include "wtf/CurrentTime.h"
26 #include "wtf/RefPtr.h" 26 #include "wtf/RefPtr.h"
27 27
28 namespace blink { 28 namespace blink {
29 29
30 LayoutProgress::LayoutProgress(HTMLElement* element) 30 LayoutProgress::LayoutProgress(HTMLProgressElement* element)
31 : LayoutBlockFlow(element) 31 : LayoutBlockFlow(element)
32 , m_position(HTMLProgressElement::InvalidPosition) 32 , m_position(HTMLProgressElement::InvalidPosition)
33 , m_animationStartTime(0) 33 , m_animationStartTime(0)
34 , m_animationRepeatInterval(0) 34 , m_animationRepeatInterval(0)
35 , m_animationDuration(0) 35 , m_animationDuration(0)
36 , m_animating(false) 36 , m_animating(false)
37 , m_animationTimer(this, &LayoutProgress::animationTimerFired) 37 , m_animationTimer(this, &LayoutProgress::animationTimerFired)
38 { 38 {
39 } 39 }
40 40
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 if (m_animating) { 104 if (m_animating) {
105 m_animationStartTime = currentTime(); 105 m_animationStartTime = currentTime();
106 m_animationTimer.startOneShot(m_animationRepeatInterval, BLINK_FROM_HERE ); 106 m_animationTimer.startOneShot(m_animationRepeatInterval, BLINK_FROM_HERE );
107 } else { 107 } else {
108 m_animationTimer.stop(); 108 m_animationTimer.stop();
109 } 109 }
110 } 110 }
111 111
112 HTMLProgressElement* LayoutProgress::progressElement() const 112 HTMLProgressElement* LayoutProgress::progressElement() const
113 { 113 {
114 if (!node()) 114 return toHTMLProgressElement(node());
115 return nullptr;
116
117 if (isHTMLProgressElement(*node()))
118 return toHTMLProgressElement(node());
119
120 ASSERT(node()->shadowHost());
121 return toHTMLProgressElement(node()->shadowHost());
122 } 115 }
123 116
124 } // namespace blink 117 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutProgress.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698