Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 1958093002: CONTINUED Make FrameSelection to hold non-canonicalized positions Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2017-01-16T20:04:35 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index 70693ab1bb91a858754eb9e84fa5efa1e13bac08..0ec13d0a4b69ba796ccc050bdcc5c2ae41b97855 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1542,9 +1542,18 @@ StyleDifference LayoutObject::adjustStyleDifference(
// be skipped or we will miss invalidating decorations (e.g.,
// underlines).
|| (isText() && !isBR() && toLayoutText(this)->hasTextBoxes())
- // Caret is painted in text color.
- || (isLayoutBlock() && toLayoutBlock(this)->hasCaret()) ||
- (isSVG() && style()->svgStyle().isFillColorCurrentColor()) ||
+#if 0
+ // TODO(yosin): Do we really need to invalidate |LayoutBlock| if
+ // it has caret? Caret rect invalidation should be done by
+ // |CaretBase| class. Also, we don't know caret position until
+ // layout finished, so we can't check whether this |LayoutBlock|
+ // has caret or not here.
+ // Caret is painted in text color.
+ // See http://crrev.com/1381353003
+ // Test: paint/invalidation/caret-color.html
+ || (isLayoutBlock() && toLayoutBlock(this)->hasCaret())
+#endif
+ || (isSVG() && style()->svgStyle().isFillColorCurrentColor()) ||
(isSVG() && style()->svgStyle().isStrokeColorCurrentColor()) ||
isListMarker())
diff.setNeedsPaintInvalidationObject();
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698