CONTINUED Make FrameSelection to hold non-canonicalized positions

third_party/WebKit/Source/core/layout/LayoutObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  *               (http://www.torchmobile.com/)
@@ skipping 1524 matching lines @@
 
   // Optimization: for decoration/color property changes, invalidation is only
   // needed if we have style or text affected by these properties.
   if (diff.textDecorationOrColorChanged() && !diff.needsPaintInvalidation()) {
     if (style()->hasBorder() || style()->hasOutline() ||
         style()->hasBackgroundRelatedColorReferencingCurrentColor()
         // Skip any text nodes that do not contain text boxes. Whitespace cannot
         // be skipped or we will miss invalidating decorations (e.g.,
         // underlines).
         || (isText() && !isBR() && toLayoutText(this)->hasTextBoxes())
-        // Caret is painted in text color.
-        || (isLayoutBlock() && toLayoutBlock(this)->hasCaret()) ||
-        (isSVG() && style()->svgStyle().isFillColorCurrentColor()) ||
+#if 0
+            // TODO(yosin): Do we really need to invalidate |LayoutBlock| if
+            // it has caret? Caret rect invalidation should be done by
+            // |CaretBase| class. Also, we don't know caret position until
+            // layout finished, so we can't check whether this |LayoutBlock|
+            // has caret or not here.
+            // Caret is painted in text color.
+            // See http://crrev.com/1381353003
+            // Test: paint/invalidation/caret-color.html
+            || (isLayoutBlock() && toLayoutBlock(this)->hasCaret())
+#endif
+        || (isSVG() && style()->svgStyle().isFillColorCurrentColor()) ||
         (isSVG() && style()->svgStyle().isStrokeColorCurrentColor()) ||
         isListMarker())
       diff.setNeedsPaintInvalidationObject();
   }
 
   // The answer to layerTypeRequired() for plugins, iframes, and canvas can
   // change without the actual style changing, since it depends on whether we
   // decide to composite these elements. When the/ layer status of one of these
   // elements changes, we need to force a layout.
   if (!diff.needsFullLayout() && style() && isBoxModelObject()) {
@@ skipping 1950 matching lines @@
     const blink::LayoutObject* root = object1;
     while (root->parent())
       root = root->parent();
     root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
   } else {
     WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
   }
 }
 
 #endif