third_party/WebKit/Source/core/page/FocusController.cpp - Issue 1958093002: CONTINUED Make FrameSelection to hold non-canonicalized positions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FocusController.cpp

Issue 1958093002: CONTINUED Make FrameSelection to hold non-canonicalized positions Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2017-01-16T20:04:35 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/FocusController.cpp

diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp

index de9da91658722ce16c2e4d1f9ba55da8cf1a3666..01e6583590c348f1ebcc1df00d580dc2d5c1607b 100644

--- a/third_party/WebKit/Source/core/page/FocusController.cpp

+++ b/third_party/WebKit/Source/core/page/FocusController.cpp

@@ -1068,10 +1068,11 @@ static void clearSelectionIfNeeded(LocalFrame* oldFocusedFrame,

return;

FrameSelection& selection = oldFocusedFrame->selection();

- if (selection.isNone())

+ const SelectionInDOMTree& selectionInDOMTree = selection.selectionInDOMTree();

+ if (selectionInDOMTree.isNone())

return;

- Node* selectionStartNode = selection.selection().start().anchorNode();

+ Node* selectionStartNode = selectionInDOMTree.base().anchorNode();

if (selectionStartNode == newFocusedElement ||

selectionStartNode->isDescendantOf(newFocusedElement))

return;

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »