Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 195803003: cc: Remove OverdrawMetrics and --trace-overdraw flag. (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
Reviewers:
jamesr, enne (OOO), piman
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, jam, darin-cc_chromium.org, piman
Visibility:
Public.

Description

cc: Remove OverdrawMetrics and --trace-overdraw flag. These metrics are only recorded when --trace-overdraw is specified, which means they are never recorded in practice because they are too expensive to record. They get in the way of inverting the occlusion relationship with AppendQuads, so remove them. R=enne@chromium.org, piman@chromium.org, enne BUG=344962, 351493 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256630

Patch Set 1 #

Patch Set 2 : rm-overdraw: #

Patch Set 3 : rm-overdraw: compile cc_perftests #

Patch Set 4 : rm-overdraw: switches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -844 lines) Patch
M cc/base/switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D cc/debug/overdraw_metrics.h View 1 chunk +0 lines, -115 lines 0 comments Download
D cc/debug/overdraw_metrics.cc View 1 chunk +0 lines, -269 lines 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M cc/layers/tiled_layer.cc View 5 chunks +0 lines, -19 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 22 chunks +2 lines, -185 lines 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/test/test_occlusion_tracker.h View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 5 chunks +3 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 3 chunks +1 line, -12 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/occlusion_tracker.h View 4 chunks +1 line, -9 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 2 chunks +1 line, -4 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M cc/trees/quad_culler.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M cc/trees/quad_culler_unittest.cc View 29 chunks +15 lines, -167 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
danakj
6 years, 9 months ago (2014-03-11 21:46:20 UTC) #1
enne (OOO)
lgtm
6 years, 9 months ago (2014-03-11 21:51:59 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-11 21:53:15 UTC) #3
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 9 months ago (2014-03-11 21:53:17 UTC) #4
danakj
+jamesr content/renderer removing a setting+flag
6 years, 9 months ago (2014-03-11 21:53:42 UTC) #5
piman
drive-by LGTM for content/
6 years, 9 months ago (2014-03-11 21:54:58 UTC) #6
danakj
Thanks :)
6 years, 9 months ago (2014-03-11 22:04:16 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-11 22:05:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/195803003/20001
6 years, 9 months ago (2014-03-11 22:37:27 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 23:54:59 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=122887
6 years, 9 months ago (2014-03-11 23:54:59 UTC) #11
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-11 23:57:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/195803003/40001
6 years, 9 months ago (2014-03-12 00:00:06 UTC) #13
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-12 00:08:19 UTC) #14
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
6 years, 9 months ago (2014-03-12 00:13:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/195803003/50001
6 years, 9 months ago (2014-03-12 00:13:28 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 05:22:35 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-12 05:22:36 UTC) #18
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-12 16:32:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/195803003/50001
6 years, 9 months ago (2014-03-12 16:35:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/195803003/50001
6 years, 9 months ago (2014-03-12 17:07:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/195803003/50001
6 years, 9 months ago (2014-03-12 19:20:11 UTC) #22
danakj
6 years, 9 months ago (2014-03-12 20:36:48 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 manually as r256630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698