Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 195793016: Remove uses of CanBeNegative() in HMod. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove uses of CanBeNegative() in HMod. BUG=v8:3204 LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/a64/lithium-codegen-a64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 9 months ago (2014-03-13 08:11:16 UTC) #1
Sven Panne
lgtm
6 years, 9 months ago (2014-03-13 08:17:07 UTC) #2
Benedikt Meurer
6 years, 9 months ago (2014-03-13 08:17:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698