src/x64/lithium-codegen-x64.cc - Issue 195793016: Remove uses of CanBeNegative() in HMod.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 195793016: Remove uses of CanBeNegative() in HMod. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 51acede259a4efd3f2cd6a23f13ca71fe0311552..f350b07d5bfc64ea2acb0330bcb8569eefdfeaa8 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -1004,7 +1004,7 @@ void LCodeGen::DoModByPowerOf2I(LModByPowerOf2I* instr) {

HMod* hmod = instr->hydrogen();

int32_t mask = divisor < 0 ? -(divisor + 1) : (divisor - 1);

Label dividend_is_not_negative, done;

- if (hmod->left()->CanBeNegative()) {

+ if (hmod->CheckFlag(HValue::kLeftCanBeNegative)) {

__ testl(dividend, dividend);

__ j(not_sign, &dividend_is_not_negative, Label::kNear);

// Note that this is correct even for kMinInt operands.

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »