src/arm/lithium-codegen-arm.cc - Issue 195793016: Remove uses of CanBeNegative() in HMod.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 195793016: Remove uses of CanBeNegative() in HMod. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 2b6c0a8407e79df676f5ff667ffc4309afa65ea1..49b7a334e8ba744f84313c44f68c2857cc3e9ce4 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -1131,7 +1131,7 @@ void LCodeGen::DoModByPowerOf2I(LModByPowerOf2I* instr) {

HMod* hmod = instr->hydrogen();

int32_t mask = divisor < 0 ? -(divisor + 1) : (divisor - 1);

Label dividend_is_not_negative, done;

- if (hmod->left()->CanBeNegative()) {

+ if (hmod->CheckFlag(HValue::kLeftCanBeNegative)) {

__ cmp(dividend, Operand::Zero());

__ b(pl, &dividend_is_not_negative);

// Note that this is correct even for kMinInt operands.

« no previous file with comments | « src/a64/lithium-codegen-a64.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »