Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9911)

Unified Diff: chrome/install_static/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/BUILD.gn ('k') | chrome/installer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/BUILD.gn
diff --git a/chrome/install_static/BUILD.gn b/chrome/install_static/BUILD.gn
index 25687d277d1b518c79dc65e98259fd5646883997..14d875e0b33df4184e7ac06997ddf0d3ca7b91ae 100644
--- a/chrome/install_static/BUILD.gn
+++ b/chrome/install_static/BUILD.gn
@@ -5,34 +5,27 @@
import("//build/config/chrome_build.gni")
import("//testing/test.gni")
+assert(is_win)
+
# This file only contains utility functions which must only depend on kernel32
# and advapi32. Please don't add dependencies on other system libraries.
static_library("install_static_util") {
+ sources = [
+ "install_util.cc",
+ "install_util.h",
+ ]
+
deps = [
"//base",
]
- if (is_win) {
- # TODO(GYP) install_static_util on Windows.
- # This is a bit tricky. It seems that what's currently called
- # install_static_nacl_win64 should be a different target with a different
- # name ("installer_static_minimal"?) since it's not strictly the 64-bit
- # build of that target.
- sources = [
- "install_util.cc",
- "install_util.h",
- ]
-
- libs = [
- "kernel32.lib",
- "advapi32.lib",
- ]
-
- configs += [
- "//build/config:precompiled_headers",
+ libs = [
+ "kernel32.lib",
+ "advapi32.lib",
+ ]
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- "//build/config/compiler:no_size_t_to_int_warning",
- ]
- }
+ configs += [
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ "//build/config/compiler:no_size_t_to_int_warning",
+ ]
}
« no previous file with comments | « chrome/common/extensions/api/BUILD.gn ('k') | chrome/installer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698