chrome/installer/BUILD.gn - Issue 1957683002: Address more TODO(GYP) in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo

Patch Set: iOS Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/BUILD.gn

diff --git a/chrome/installer/BUILD.gn b/chrome/installer/BUILD.gn

index d8f7fa8dbfb4724e9b062b64395f4e7218b05dfe..8e9a1ffceed2ed4a4245caf9b42262e062690933 100644

--- a/chrome/installer/BUILD.gn

+++ b/chrome/installer/BUILD.gn

@@ -6,7 +6,7 @@ import("//build/config/chrome_build.gni")

# Meta-target that forwards to the installer of the correct type (if any).

group("installer") {

- # TODO(GYP): Get the 32-bit build to work.

+ # We only make Linux installers for 64-bit desktop.

if (is_desktop_linux && is_chrome_branded && target_cpu == "x64") {

deps = [

"//chrome/installer/linux",

« no previous file with comments | « chrome/install_static/BUILD.gn ('k') | chrome/installer/linux/BUILD.gn » ('j') | no next file with comments »