Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/install_static/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/extensions/api/BUILD.gn ('k') | chrome/installer/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 assert(is_win)
9
8 # This file only contains utility functions which must only depend on kernel32 10 # This file only contains utility functions which must only depend on kernel32
9 # and advapi32. Please don't add dependencies on other system libraries. 11 # and advapi32. Please don't add dependencies on other system libraries.
10 static_library("install_static_util") { 12 static_library("install_static_util") {
13 sources = [
14 "install_util.cc",
15 "install_util.h",
16 ]
17
11 deps = [ 18 deps = [
12 "//base", 19 "//base",
13 ] 20 ]
14 21
15 if (is_win) { 22 libs = [
16 # TODO(GYP) install_static_util on Windows. 23 "kernel32.lib",
17 # This is a bit tricky. It seems that what's currently called 24 "advapi32.lib",
18 # install_static_nacl_win64 should be a different target with a different 25 ]
19 # name ("installer_static_minimal"?) since it's not strictly the 64-bit
20 # build of that target.
21 sources = [
22 "install_util.cc",
23 "install_util.h",
24 ]
25 26
26 libs = [ 27 configs += [
27 "kernel32.lib", 28 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
28 "advapi32.lib", 29 "//build/config/compiler:no_size_t_to_int_warning",
29 ] 30 ]
30
31 configs += [
32 "//build/config:precompiled_headers",
33
34 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
35 "//build/config/compiler:no_size_t_to_int_warning",
36 ]
37 }
38 } 31 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/api/BUILD.gn ('k') | chrome/installer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698