Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1957673002: Less duplicated code between nodeAtPoint() in LayoutBox and LayoutBlock. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Less duplicated code between nodeAtPoint() in LayoutBox and LayoutBlock. This is a preparatory patch for moving line/float-specific parts of LayoutBlock::hitTestChildren() into LayoutBlockFlow. BUG=302024 Committed: https://crrev.com/bdc54b5ca7a098e251ff63d9ae1b38dcd5b467f1 Cr-Commit-Position: refs/heads/master@{#392116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -50 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +2 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +20 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-06 13:14:07 UTC) #2
wkorman
lgtm
4 years, 7 months ago (2016-05-06 18:36:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957673002/1
4 years, 7 months ago (2016-05-06 19:12:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 19:17:24 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bdc54b5ca7a098e251ff63d9ae1b38dcd5b467f1 Cr-Commit-Position: refs/heads/master@{#392116}
4 years, 7 months ago (2016-05-06 19:20:02 UTC) #8
eae
4 years, 7 months ago (2016-05-09 15:33:42 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698