Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1957673002: Less duplicated code between nodeAtPoint() in LayoutBox and LayoutBlock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 778
779 PositionWithAffinity positionForPoint(const LayoutPoint&) override; 779 PositionWithAffinity positionForPoint(const LayoutPoint&) override;
780 780
781 void removeFloatingOrPositionedChildFromBlockLists(); 781 void removeFloatingOrPositionedChildFromBlockLists();
782 782
783 PaintLayer* enclosingFloatPaintingLayer() const; 783 PaintLayer* enclosingFloatPaintingLayer() const;
784 784
785 virtual int firstLineBoxBaseline() const { return -1; } 785 virtual int firstLineBoxBaseline() const { return -1; }
786 virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // R eturns -1 if we should skip this box when computing the baseline of an inline-bl ock. 786 virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // R eturns -1 if we should skip this box when computing the baseline of an inline-bl ock.
787 787
788 virtual Node* nodeForHitTest() const { return node(); }
789
788 bool shrinkToAvoidFloats() const; 790 bool shrinkToAvoidFloats() const;
789 virtual bool avoidsFloats() const; 791 virtual bool avoidsFloats() const;
790 792
791 virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&); 793 virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&);
792 794
793 bool isWritingModeRoot() const { return !parent() || parent()->style()->getW ritingMode() != style()->getWritingMode(); } 795 bool isWritingModeRoot() const { return !parent() || parent()->style()->getW ritingMode() != style()->getWritingMode(); }
794 bool isOrthogonalWritingModeRoot() const { return parent() && parent()->isHo rizontalWritingMode() != isHorizontalWritingMode(); } 796 bool isOrthogonalWritingModeRoot() const { return parent() && parent()->isHo rizontalWritingMode() != isHorizontalWritingMode(); }
795 void markOrthogonalWritingModeRoot(); 797 void markOrthogonalWritingModeRoot();
796 void unmarkOrthogonalWritingModeRoot(); 798 void unmarkOrthogonalWritingModeRoot();
797 799
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
1032 { 1034 {
1033 // The frame rect may change because of layout of other objects. 1035 // The frame rect may change because of layout of other objects.
1034 // Should check this object for paint invalidation. 1036 // Should check this object for paint invalidation.
1035 if (!needsLayout()) 1037 if (!needsLayout())
1036 setMayNeedPaintInvalidation(); 1038 setMayNeedPaintInvalidation();
1037 } 1039 }
1038 1040
1039 // Returns true if the box intersects the viewport visible to the user. 1041 // Returns true if the box intersects the viewport visible to the user.
1040 bool intersectsVisibleViewport(); 1042 bool intersectsVisibleViewport();
1041 1043
1042 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction); 1044 virtual bool isInSelfHitTestingPhase(HitTestAction hitTestAction) const { re turn hitTestAction == HitTestForeground; }
1045 virtual bool hitTestChildren(HitTestResult&, const HitTestLocation& location InContainer, const LayoutPoint& accumulatedOffset, HitTestAction);
1043 1046
1044 void updateBackgroundAttachmentFixedStatusAfterStyleChange(); 1047 void updateBackgroundAttachmentFixedStatusAfterStyleChange();
1045 1048
1046 // The CSS border box rect for this box. 1049 // The CSS border box rect for this box.
1047 // 1050 //
1048 // The rectangle is in this box's physical coordinates but with a 1051 // The rectangle is in this box's physical coordinates but with a
1049 // flipped block-flow direction (see the COORDINATE SYSTEMS section 1052 // flipped block-flow direction (see the COORDINATE SYSTEMS section
1050 // in LayoutBoxModelObject). The location is the distance from this 1053 // in LayoutBoxModelObject). The location is the distance from this
1051 // object's border edge to the container's border edge (which is not 1054 // object's border edge to the container's border edge (which is not
1052 // always the parent). Thus it includes any logical top/left along 1055 // always the parent). Thus it includes any logical top/left along
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
1164 || breakValue == BreakLeft 1167 || breakValue == BreakLeft
1165 || breakValue == BreakPage 1168 || breakValue == BreakPage
1166 || breakValue == BreakRecto 1169 || breakValue == BreakRecto
1167 || breakValue == BreakRight 1170 || breakValue == BreakRight
1168 || breakValue == BreakVerso; 1171 || breakValue == BreakVerso;
1169 } 1172 }
1170 1173
1171 } // namespace blink 1174 } // namespace blink
1172 1175
1173 #endif // LayoutBox_h 1176 #endif // LayoutBox_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698