Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1957673002: Less duplicated code between nodeAtPoint() in LayoutBox and LayoutBlock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 390
391 void makeChildrenInlineIfPossible(); 391 void makeChildrenInlineIfPossible();
392 392
393 void dirtyLinesFromChangedChild(LayoutObject* child) final { m_lineBoxes.dir tyLinesFromChangedChild(LineLayoutItem(this), LineLayoutItem(child)); } 393 void dirtyLinesFromChangedChild(LayoutObject* child) final { m_lineBoxes.dir tyLinesFromChangedChild(LineLayoutItem(this), LineLayoutItem(child)); }
394 394
395 void addChildIgnoringContinuation(LayoutObject* newChild, LayoutObject* befo reChild) override; 395 void addChildIgnoringContinuation(LayoutObject* newChild, LayoutObject* befo reChild) override;
396 396
397 TrackedLayoutBoxListHashSet* positionedObjectsInternal() const; 397 TrackedLayoutBoxListHashSet* positionedObjectsInternal() const;
398 TrackedLayoutBoxListHashSet* percentHeightDescendantsInternal() const; 398 TrackedLayoutBoxListHashSet* percentHeightDescendantsInternal() const;
399 399
400 Node* nodeForHitTest() const; 400 Node* nodeForHitTest() const final;
401 401
402 // Returns true if the positioned movement-only layout succeeded. 402 // Returns true if the positioned movement-only layout succeeded.
403 bool tryLayoutDoingPositionedMovementOnly(); 403 bool tryLayoutDoingPositionedMovementOnly();
404 404
405 bool avoidsFloats() const override { return true; } 405 bool avoidsFloats() const override { return true; }
406 406
407 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction); 407 bool isInSelfHitTestingPhase(HitTestAction hitTestAction) const final
408 {
409 return hitTestAction == HitTestBlockBackground || hitTestAction == HitTe stChildBlockBackground;
410 }
411 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction) override;
408 // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to Layo utBlockFlow 412 // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to Layo utBlockFlow
409 virtual bool hitTestFloats(HitTestResult&, const HitTestLocation&, const Lay outPoint&) { return false; } 413 virtual bool hitTestFloats(HitTestResult&, const HitTestLocation&, const Lay outPoint&) { return false; }
410 414
411 bool isPointInOverflowControl(HitTestResult&, const LayoutPoint& locationInC ontainer, const LayoutPoint& accumulatedOffset) const; 415 bool isPointInOverflowControl(HitTestResult&, const LayoutPoint& locationInC ontainer, const LayoutPoint& accumulatedOffset) const;
412 416
413 void computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutU nit& maxLogicalWidth) const; 417 void computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutU nit& maxLogicalWidth) const;
414 418
415 LayoutObject* hoverAncestor() const final; 419 LayoutObject* hoverAncestor() const final;
416 void updateDragState(bool dragOn) final; 420 void updateDragState(bool dragOn) final;
417 void childBecameNonInline(LayoutObject* child) final; 421 void childBecameNonInline(LayoutObject* child) final;
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 // FIXME: This is temporary as we move code that accesses block flow 507 // FIXME: This is temporary as we move code that accesses block flow
504 // member variables out of LayoutBlock and into LayoutBlockFlow. 508 // member variables out of LayoutBlock and into LayoutBlockFlow.
505 friend class LayoutBlockFlow; 509 friend class LayoutBlockFlow;
506 }; 510 };
507 511
508 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 512 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
509 513
510 } // namespace blink 514 } // namespace blink
511 515
512 #endif // LayoutBlock_h 516 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698