Issue 19576005: Revert 212020 "Move Python setup/tear down logic into Forwarder ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19576005: Revert 212020 "Move Python setup/tear down logic into Forwarder ..." (Closed)

Created:
7 years, 5 months ago by Philippe

Modified:
7 years, 5 months ago

Reviewers:
Philippe

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 212020 "Move Python setup/tear down logic into Forwarder ..." This causes flakiness on the Android debug tester bot. > Move Python setup/tear down logic into Forwarder itself. > > Forwarder used to be a pain to setup/tear down across all the various > harnesses. > This CL should hopefully solve these issues by hiding these implementation > details. The host daemon is now killed once the first time that the Forwarder > class is used and the daemon running on the devices is also killed the first > time a port is forwarded for a specific device. > > BUG=242846 > R=bulach@chromium.org, frankf@chromium.org > > Review URL: https://codereview.chromium.org/18086004 TBR=pliard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212054

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+176 lines, -252 lines)			Patch
MM	trunk/src/build/android/adb_reverse_forwarder.py	View	2 chunks	+6 lines, -2 lines	0 comments	Download
MM	trunk/src/build/android/bb_run_sharded_steps.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/src/build/android/pylib/base/base_test_runner.py	View	4 chunks	+30 lines, -15 lines	0 comments	Download
M	trunk/src/build/android/pylib/base/shard.py	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	trunk/src/build/android/pylib/chrome_test_server_spawner.py	View	8 chunks	+11 lines, -6 lines	0 comments	Download
M	trunk/src/build/android/pylib/forwarder.py	View	5 chunks	+82 lines, -211 lines	0 comments	Download
M	trunk/src/build/android/pylib/host_driven/python_test_sharder.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/build/android/pylib/instrumentation/test_runner.py	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/test/chromedriver/run_py_tests.py	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/test/chromedriver/test_environment.py	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/core/chrome/adb_commands.py	View	2 chunks	+16 lines, -5 lines	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/core/chrome/android_browser_backend.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r212054.

Expand Messages | Collapse Messages