Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: trunk/src/build/android/pylib/instrumentation/test_runner.py

Issue 19576005: Revert 212020 "Move Python setup/tear down logic into Forwarder ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/build/android/pylib/instrumentation/test_runner.py
===================================================================
--- trunk/src/build/android/pylib/instrumentation/test_runner.py (revision 212053)
+++ trunk/src/build/android/pylib/instrumentation/test_runner.py (working copy)
@@ -153,13 +153,11 @@
http_server_ports = self.LaunchTestHttpServer(
os.path.join(constants.DIR_SOURCE_ROOT), self._lighttp_port)
if self.ports_to_forward:
- self.ForwardPorts([(port, port) for port in self.ports_to_forward])
+ self.StartForwarder([(port, port) for port in self.ports_to_forward])
self.flags.AddFlags(['--enable-test-intents'])
def TearDown(self):
"""Cleans up the test harness and saves outstanding data from test run."""
- if self.ports_to_forward:
- self._UnmapPortPairs(self.ports_to_forward)
super(TestRunner, self).TearDown()
def TestSetup(self, test):
@@ -172,6 +170,9 @@
self._SetupIndividualTestTimeoutScale(test)
self.tool.SetupEnvironment()
+ # Make sure the forwarder is still running.
+ self.RestartHttpServerForwarderIfNecessary()
+
def _IsPerfTest(self, test):
"""Determines whether a test is a performance test.
« no previous file with comments | « trunk/src/build/android/pylib/host_driven/python_test_sharder.py ('k') | trunk/src/chrome/test/chromedriver/run_py_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698