Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: trunk/src/chrome/test/chromedriver/test_environment.py

Issue 19576005: Revert 212020 "Move Python setup/tear down logic into Forwarder ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/test/chromedriver/test_environment.py
===================================================================
--- trunk/src/chrome/test/chromedriver/test_environment.py (revision 212053)
+++ trunk/src/chrome/test/chromedriver/test_environment.py (working copy)
@@ -94,14 +94,19 @@
os.putenv('TEST_HTTP_PORT', str(ANDROID_TEST_HTTP_PORT))
os.putenv('TEST_HTTPS_PORT', str(ANDROID_TEST_HTTPS_PORT))
self._adb = android_commands.AndroidCommands()
- forwarder.Forwarder.Map(
+ forwarder.Forwarder.KillHost('Debug')
+ self._forwarder = forwarder.Forwarder(self._adb, 'Debug')
+ self._forwarder.Run(
[(ANDROID_TEST_HTTP_PORT, ANDROID_TEST_HTTP_PORT),
(ANDROID_TEST_HTTPS_PORT, ANDROID_TEST_HTTPS_PORT)],
- self._adb)
+ valgrind_tools.BaseTool())
# override
def GlobalTearDown(self):
- forwarder.Forwarder.UnmapAllDevicePorts(self._adb)
+ if self._adb is not None:
+ forwarder.Forwarder.KillDevice(self._adb, valgrind_tools.BaseTool())
+ if self._forwarder is not None:
+ self._forwarder.Close()
# override
def GetOS(self):
« no previous file with comments | « trunk/src/chrome/test/chromedriver/run_py_tests.py ('k') | trunk/src/tools/telemetry/telemetry/core/chrome/adb_commands.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698