Exclude scrollbars from visual viewport dimensions

Exclude scrollbars from visual viewport dimensions

BUG=604926
Committed: https://crrev.com/47b194637cd2062a5bc058362f977515f819c712
Cr-Commit-Position: refs/heads/master@{#393641}

[ymalik, 2016-05-08 05:31:55]

ymalik@chromium.org changed reviewers:
+ bokan@chromium.org

[bokan, 2016-05-09 13:03:27]

lgtm, nice tests!

https://codereview.chromium.org/1957103002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
(right):

https://codereview.chromium.org/1957103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html:17:
async_test(function(t) {
Just curious, why do the tests have to be async?

[ymalik, 2016-05-09 15:37:43]

https://codereview.chromium.org/1957103002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
(right):

https://codereview.chromium.org/1957103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html:17:
async_test(function(t) {
On 2016/05/09 13:03:27, bokan wrote:
> Just curious, why do the tests have to be async?

If the test are no async, they finish before the scrollbars are added (before
onload). So they were still passing with my change.

[ymalik, 2016-05-09 15:38:37]

ymalik@chromium.org changed reviewers:
+ jbroman@chromium.org

[ymalik, 2016-05-09 15:38:39]

+jbroman for Source/platform/scroll/ScrollableArea.cpp

[jbroman, 2016-05-13 17:28:25]

platform lgtm

(sorry for the delay)

https://codereview.chromium.org/1957103002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/ScrollableArea.h (right):

https://codereview.chromium.org/1957103002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/ScrollableArea.h:271: // Returns 0 if
overlay scrollbars are enabled.
nit: blank line before this, please

[ymalik, 2016-05-13 18:26:44]

https://codereview.chromium.org/1957103002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/ScrollableArea.h (right):

https://codereview.chromium.org/1957103002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/ScrollableArea.h:271: // Returns 0 if
overlay scrollbars are enabled.
On 2016/05/13 17:28:25, jbroman wrote:
> nit: blank line before this, please

Done.

[ymalik, 2016-05-13 18:27:09]

The CQ bit was checked by ymalik@chromium.org

[ymalik, 2016-05-13 18:27:09]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1957103002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-05-13 18:27:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957103002/40001

[commit-bot: I haz the power, 2016-05-13 21:09:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-13 21:11:12]

Description was changed from

==========
Exclude scrollbars from visual viewport dimensions

BUG=604926
==========

to

==========
Exclude scrollbars from visual viewport dimensions

BUG=604926

Committed: https://crrev.com/47b194637cd2062a5bc058362f977515f819c712
Cr-Commit-Position: refs/heads/master@{#393641}
==========

[commit-bot: I haz the power, 2016-05-13 21:11:13]

Patchset 3 (id:??) landed as
https://crrev.com/47b194637cd2062a5bc058362f977515f819c712
Cr-Commit-Position: refs/heads/master@{#393641}