Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 1957103002: Exclude scrollbars from visual viewport dimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update test description Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 // TODO(bokan): FrameView::setScrollPosition uses updateScrollbars to scroll 261 // TODO(bokan): FrameView::setScrollPosition uses updateScrollbars to scroll
262 // which bails out early if its already in updateScrollbars, the effect bein g 262 // which bails out early if its already in updateScrollbars, the effect bein g
263 // that programmatic scrolls (i.e. setScrollPosition) are disabled when in 263 // that programmatic scrolls (i.e. setScrollPosition) are disabled when in
264 // updateScrollbars. Expose this here to allow RootFrameViewport to match th e 264 // updateScrollbars. Expose this here to allow RootFrameViewport to match th e
265 // semantics for now but it should be cleaned up at the source. 265 // semantics for now but it should be cleaned up at the source.
266 virtual bool isProgrammaticallyScrollable() { return true; } 266 virtual bool isProgrammaticallyScrollable() { return true; }
267 267
268 // Subtracts space occupied by this ScrollableArea's scrollbars. 268 // Subtracts space occupied by this ScrollableArea's scrollbars.
269 // Does nothing if overlay scrollbars are enabled. 269 // Does nothing if overlay scrollbars are enabled.
270 IntSize excludeScrollbars(const IntSize&) const; 270 IntSize excludeScrollbars(const IntSize&) const;
271 // Returns 0 if overlay scrollbars are enabled.
jbroman 2016/05/13 17:28:25 nit: blank line before this, please
ymalik 2016/05/13 18:26:44 Done.
272 int verticalScrollbarWidth() const;
273 int horizontalScrollbarHeight() const;
271 274
272 // Returns the widget associated with this ScrollableArea. 275 // Returns the widget associated with this ScrollableArea.
273 virtual Widget* getWidget() { return nullptr; } 276 virtual Widget* getWidget() { return nullptr; }
274 277
275 virtual bool isFrameView() const { return false; } 278 virtual bool isFrameView() const { return false; }
276 virtual bool isPaintLayerScrollableArea() const { return false; } 279 virtual bool isPaintLayerScrollableArea() const { return false; }
277 280
278 // Need to promptly let go of owned animator objects. 281 // Need to promptly let go of owned animator objects.
279 EAGERLY_FINALIZE(); 282 EAGERLY_FINALIZE();
280 DECLARE_VIRTUAL_TRACE(); 283 DECLARE_VIRTUAL_TRACE();
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 // vertical-lr / ltr NO NO 339 // vertical-lr / ltr NO NO
337 // vertical-lr / rtl NO YES 340 // vertical-lr / rtl NO YES
338 // vertical-rl / ltr YES NO 341 // vertical-rl / ltr YES NO
339 // vertical-rl / rtl YES YES 342 // vertical-rl / rtl YES YES
340 IntPoint m_scrollOrigin; 343 IntPoint m_scrollOrigin;
341 }; 344 };
342 345
343 } // namespace blink 346 } // namespace blink
344 347
345 #endif // ScrollableArea_h 348 #endif // ScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698