third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html - Issue 1957103002: Exclude scrollbars from visual viewport dimensions

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html

Issue 1957103002: Exclude scrollbars from visual viewport dimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html ('k') | third_party/WebKit/Source/core/frame/VisualViewport.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 body {	3 body {

4 height: 2000px;	4 height: 2000px;

5 width: 2000px;	5 width: 2000px;

6 }	6 }

	7 ::-webkit-scrollbar {

	8 width: 0px;

	9 height: 0px;

	10 }

7 </style>	11 </style>

8 <script src="../../../resources/testharness.js"></script>	12 <script src="../../../resources/testharness.js"></script>

9 <script src="../../../resources/testharnessreport.js"></script>	13 <script src="../../../resources/testharnessreport.js"></script>

10 <script>	14 <script>

11 var browserZoomFactor = 1.25;	15 var browserZoomFactor = 1.25;

12	16

13 test(function() {	17 async_test(function(t) {

14 window.scrollTo(100, 100);	18 window.onload = t.step_func(function() {

	19 window.scrollTo(100, 100);

15	20

16 // TODO(ymalik): Remove hook to internals to pinch-zoom here and browser	21 // TODO(ymalik): Remove hook to internals to pinch-zoom here and browser

17 // zoom below. This will be required to upstream to w3c repo.	22 // zoom below. This will be required to upstream to w3c repo.

18 internals.setPageScaleFactor(2);	23 internals.setPageScaleFactor(2);

19	24

20 // Offset visual viewport by 10px.	25 // Offset visual viewport by 10px.

21 document.visualViewport.scrollTop = 10;	26 document.visualViewport.scrollTop = 10;

22 document.visualViewport.scrollLeft = 10;	27 document.visualViewport.scrollLeft = 10;

23	28

24 assert_equals(document.visualViewport.scrollTop, 10);	29 assert_equals(document.visualViewport.scrollTop, 10);

25 assert_equals(document.visualViewport.scrollLeft, 10);	30 assert_equals(document.visualViewport.scrollLeft, 10);

26 assert_equals(document.visualViewport.clientWidth, 400);	31 assert_equals(document.visualViewport.clientWidth, 400);

27 assert_equals(document.visualViewport.clientHeight, 300);	32 assert_equals(document.visualViewport.clientHeight, 300);

28 assert_equals(document.visualViewport.pageScale, 2);	33 assert_equals(document.visualViewport.pageScale, 2);

29	34

30 // Apply browser zoom.	35 // Apply browser zoom.

31 window.internals.setZoomFactor(browserZoomFactor);	36 window.internals.setZoomFactor(browserZoomFactor);

32	37

33 // Visual viewport dimensions should be scaled by the browser zoom factor.	38 // Visual viewport dimensions should be scaled by the browser zoom factor.

34 assert_equals(document.visualViewport.scrollTop, 10 / browserZoomFactor);	39 assert_equals(document.visualViewport.scrollTop, 10 / browserZoomFactor);

35 assert_equals(document.visualViewport.scrollLeft, 10 / browserZoomFactor);	40 assert_equals(document.visualViewport.scrollLeft, 10 / browserZoomFactor);

36 assert_equals(document.visualViewport.clientWidth, 400 / browserZoomFactor);	41 assert_equals(document.visualViewport.clientWidth, 400 / browserZoomFactor );

37 assert_equals(document.visualViewport.clientHeight, 300 / browserZoomFactor) ;	42 assert_equals(document.visualViewport.clientHeight, 300 / browserZoomFacto r);

38 assert_equals(document.visualViewport.pageScale, 2);	43 assert_equals(document.visualViewport.pageScale, 2);

39	44

40 // Verify setting the visual viewport offset under browser zoom.	45 // Verify setting the visual viewport offset under browser zoom.

41 document.visualViewport.scrollTop = 12.5;	46 document.visualViewport.scrollTop = 12.5;

42 document.visualViewport.scrollLeft = 12.5;	47 document.visualViewport.scrollLeft = 12.5;

43 assert_equals(document.visualViewport.scrollTop, 12.5);	48 assert_equals(document.visualViewport.scrollTop, 12.5);

44 assert_equals(document.visualViewport.scrollLeft, 12.5);	49 assert_equals(document.visualViewport.scrollLeft, 12.5);

45 assert_equals(document.visualViewport.clientWidth, 400 / browserZoomFactor);	50 assert_equals(document.visualViewport.clientWidth, 400 / browserZoomFactor );

46 assert_equals(document.visualViewport.clientHeight, 300 / browserZoomFactor) ;	51 assert_equals(document.visualViewport.clientHeight, 300 / browserZoomFacto r);

47 assert_equals(document.visualViewport.pageScale, 2);	52 assert_equals(document.visualViewport.pageScale, 2);

	53 t.done();

	54 });

48 }, 'Verify viewport dimensions under bowser zoom.');	55 }, 'Verify viewport dimensions under bowser zoom.');

49 </script>	56 </script>

OLD	NEW