[Part 1 of 6] Move MockWebContentsTaskManager into its own file.

Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.
Remove the mostly redundant task manager PanelBrowserTests
(these are actually interactive_ui_tests). Extend
TaskManagerBrowserTest.NoticePanel to replace lost coverage.

BUG=606963
Committed: https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0
Cr-Commit-Position: refs/heads/master@{#392428}

[ncarter (slow), 2016-05-06 17:30:16]

nick@chromium.org changed reviewers:
+ afakhry@chromium.org

[ncarter (slow), 2016-05-06 17:30:17]

Ahmed, please review.

[ncarter (slow), 2016-05-06 18:14:37]

Description was changed from

==========
Move MockWebContentsTaskManager into its own file.

BUG=606963
==========

to

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1]

BUG=606963
==========

[ncarter (slow), 2016-05-06 18:49:12]

https://codereview.chromium.org/1956813002/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1956813002/diff/20001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:3020:
'browser/task_management/mock_web_contents_task_manager.h',
Actually, come to think of it: these are test files, and belong in
chrome_tests.gypi

[ncarter (slow), 2016-05-06 20:42:34]

Description was changed from

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1]

BUG=606963
==========

to

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.

Remove the mostly redundant task manager PanelBrowserTests (these are actually
interactive_ui_tests). Extend TaskManagerBrowserTest.NoticePanel
to replace lost coverage.

BUG=606963
==========

[ncarter (slow), 2016-05-06 22:27:34]

Description was changed from

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.

Remove the mostly redundant task manager PanelBrowserTests (these are actually
interactive_ui_tests). Extend TaskManagerBrowserTest.NoticePanel
to replace lost coverage.

BUG=606963
==========

to

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.

Remove the mostly redundant task manager PanelBrowserTests (these are actually
interactive_ui_tests). Extend TaskManagerBrowserTest.NoticePanel
to replace lost coverage.

BUG=606963
==========

[afakhry, 2016-05-06 23:52:03]

lgtm with one comment.

https://codereview.chromium.org/1956813002/diff/80001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

https://codereview.chromium.org/1956813002/diff/80001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_browsertest.cc:330:
PanelManager::CREATE_AS_DETACHED);
Can you also create a panel with SHOW_AS_INACTIVE? Just to make sure we didn't
lose coverage for that?

[ncarter (slow), 2016-05-09 16:43:03]

https://codereview.chromium.org/1956813002/diff/80001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

https://codereview.chromium.org/1956813002/diff/80001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_browsertest.cc:330:
PanelManager::CREATE_AS_DETACHED);
On 2016/05/06 23:52:02, afakhry wrote:
> Can you also create a panel with SHOW_AS_INACTIVE? Just to make sure we didn't
> lose coverage for that?

Done. I've added calls to panel->Show() / panel->ShowInactive() throughout these
tests, so we have even better coverage than before.

[ncarter (slow), 2016-05-09 16:45:11]

nick@chromium.org changed reviewers:
+ thestig@chromium.org

[ncarter (slow), 2016-05-09 16:45:12]

Lei, please review for chrome/ OWNERS

[afakhry, 2016-05-09 17:35:36]

https://codereview.chromium.org/1956813002/diff/80001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

https://codereview.chromium.org/1956813002/diff/80001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_browsertest.cc:330:
PanelManager::CREATE_AS_DETACHED);
On 2016/05/09 16:43:03, ncarter wrote:
> On 2016/05/06 23:52:02, afakhry wrote:
> > Can you also create a panel with SHOW_AS_INACTIVE? Just to make sure we
didn't
> > lose coverage for that?
> 
> Done. I've added calls to panel->Show() / panel->ShowInactive() throughout
these
> tests, so we have even better coverage than before.

Thanks!

[Lei Zhang, 2016-05-09 21:31:26]

Description was changed from

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.

Remove the mostly redundant task manager PanelBrowserTests (these are actually
interactive_ui_tests). Extend TaskManagerBrowserTest.NoticePanel
to replace lost coverage.

BUG=606963
==========

to

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.
Remove the mostly redundant task manager PanelBrowserTests
(these are actually interactive_ui_tests). Extend
TaskManagerBrowserTest.NoticePanel to replace lost coverage.

BUG=606963
==========

[Lei Zhang, 2016-05-09 21:33:25]

lgtm

I did some light editing on the CL description to fit within 72 columns to be
more git log friendly.

[ncarter (slow), 2016-05-09 21:35:07]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-05-09 21:35:08]

The patchset sent to the CQ was uploaded after l-g-t-m from afakhry@chromium.org
Link to the patchset: https://codereview.chromium.org/1956813002/#ps100001
(title: "Add Show() / ShowInactive() coverage.")

[commit-bot: I haz the power, 2016-05-09 21:35:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956813002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956813002/100001

[commit-bot: I haz the power, 2016-05-09 22:00:48]

Description was changed from

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.
Remove the mostly redundant task manager PanelBrowserTests
(these are actually interactive_ui_tests). Extend
TaskManagerBrowserTest.NoticePanel to replace lost coverage.

BUG=606963
==========

to

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.
Remove the mostly redundant task manager PanelBrowserTests
(these are actually interactive_ui_tests). Extend
TaskManagerBrowserTest.NoticePanel to replace lost coverage.

BUG=606963
==========

[commit-bot: I haz the power, 2016-05-09 22:00:50]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-09 22:03:31]

Description was changed from

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.
Remove the mostly redundant task manager PanelBrowserTests
(these are actually interactive_ui_tests). Extend
TaskManagerBrowserTest.NoticePanel to replace lost coverage.

BUG=606963
==========

to

==========
Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.
Remove the mostly redundant task manager PanelBrowserTests
(these are actually interactive_ui_tests). Extend
TaskManagerBrowserTest.NoticePanel to replace lost coverage.

BUG=606963

Committed: https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0
Cr-Commit-Position: refs/heads/master@{#392428}
==========

[commit-bot: I haz the power, 2016-05-09 22:03:32]

Patchset 6 (id:??) landed as
https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0
Cr-Commit-Position: refs/heads/master@{#392428}