[Part 1 of 6] Move MockWebContentsTaskManager into its own file.

chrome/browser/task_manager/task_manager_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/task_manager.h"
 
 #include <stddef.h>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
@@ skipping 284 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticePanel) {
   ASSERT_TRUE(LoadExtension(
       test_data_dir_.AppendASCII("good").AppendASCII("Extensions")
                     .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
                     .AppendASCII("1.0.0.0")));
 
   // Open a new panel to an extension url.
   GURL url(
     "chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/french_sentence.html");
-  Panel* panel = PanelManager::GetInstance()->CreatePanel(
+  Panel* docked_panel = PanelManager::GetInstance()->CreatePanel(
       web_app::GenerateApplicationNameFromExtensionId(
           last_loaded_extension_id()),
-      browser()->profile(),
-      url,
-      nullptr,
-      gfx::Rect(300, 400),
+      browser()->profile(), url, nullptr, gfx::Rect(300, 400),
       PanelManager::CREATE_AS_DOCKED);
 
   // Make sure that a task manager model created after the panel shows the
   // existence of the panel and the extension.
   ShowTaskManager();
   ASSERT_NO_FATAL_FAILURE(
       WaitForTaskManagerRows(1, MatchExtension("My extension 1")));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(
       1,
       MatchExtension(
           "chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/"
           "french_sentence.html")));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(2, MatchAnyExtension()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
 
-  // Close the panel and verify that we notice.
-  panel->Close();
+  // Create a second, detached panel.
+  Panel* detached_panel = PanelManager::GetInstance()->CreatePanel(
+      web_app::GenerateApplicationNameFromExtensionId(
+          last_loaded_extension_id()),
+      browser()->profile(), url, nullptr, gfx::Rect(150, 150),
+      PanelManager::CREATE_AS_DETACHED);

[afakhry, 2016/05/06 23:52:02]

Can you also create a panel with SHOW_AS_INACTIVE? Just to make sure we didn't
lose coverage for that?

[ncarter (slow), 2016/05/09 16:43:03]

Done. I've added calls to panel->Show() / panel->ShowInactive() throughout these
tests, so we have even better coverage than before.

[afakhry, 2016/05/09 17:35:36]

Thanks!

+
+  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(
+      2, MatchExtension("chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/"
+                        "french_sentence.html")));
+  ASSERT_NO_FATAL_FAILURE(
+      WaitForTaskManagerRows(1, MatchExtension("My extension 1")));
+  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(3, MatchAnyExtension()));
+
+  // Close the panels and verify that we notice.
+  docked_panel->Close();
+  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(2, MatchAnyExtension()));
+  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(
+      1, MatchExtension("chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/"
+                        "french_sentence.html")));
+  ASSERT_NO_FATAL_FAILURE(
+      WaitForTaskManagerRows(1, MatchExtension("My extension 1")));
+
+  detached_panel->Close();
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyExtension()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(
       0,
       MatchExtension(
           "chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/"
           "french_sentence.html")));
   ASSERT_NO_FATAL_FAILURE(
       WaitForTaskManagerRows(1, MatchExtension("My extension 1")));
 }
 
@@ skipping 869 matching lines @@
       WaitForTaskManagerRows(1, MatchTab("Title Of Awesomeness")));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, MatchAnySubframe()));
 
   HideTaskManager();
   ShowTaskManager();
 
   ASSERT_NO_FATAL_FAILURE(
       WaitForTaskManagerRows(1, MatchTab("Title Of Awesomeness")));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, MatchAnySubframe()));
 }