Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1956473002:
Retract GrRenderTarget a bit within SkGpuDevice (Closed)
|
Created:
4 years, 7 months ago by robertphillips Modified:
4 years, 7 months ago Reviewers:
bsalomon CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionRetract GrRenderTarget a bit within SkGpuDevice
Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1956473002
Committed: https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c
Committed: https://skia.googlesource.com/skia/+/e576874b162f8c66aa6c2e06cb6bc459ccd8b6f9
Patch Set 1 #Patch Set 2 : Retract GrRenderTarget a bit within SkGpuDevice #Patch Set 3 : Remove possible regressor #
Messages
Total messages: 27 (14 generated)
Description was changed from ========== Retract GrRenderTarget a bit within SkGpuDevice ========== to ========== Retract GrRenderTarget a bit within SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Retract GrRenderTarget a bit within SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Retract GrRenderTarget a bit within SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com
Description was changed from ========== Retract GrRenderTarget a bit within SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Retract GrRenderTarget a bit within SkGpuDevice Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956473002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956473002/20001
Message was sent while issue was closed.
Description was changed from ========== Retract GrRenderTarget a bit within SkGpuDevice Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Retract GrRenderTarget a bit within SkGpuDevice Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1954103002/ by robertphillips@google.com. The reason for reverting is: Experimental revert to track down perf regression.
Message was sent while issue was closed.
Description was changed from ========== Retract GrRenderTarget a bit within SkGpuDevice Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c ========== to ========== Retract GrRenderTarget a bit within SkGpuDevice Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c ==========
On 2016/05/06 14:55:09, robertphillips wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/1954103002/ by mailto:robertphillips@google.com. > > The reason for reverting is: Experimental revert to track down perf regression. This CL, surprisingly, is the culprit in the perf regression. It only seems to occur with NVPR configs.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956473002/40001
I haven't been able to reproduce the regression locally. I have removed the only possible change that could've been causing the regression and will try to reland.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1956473002/#ps40001 (title: "Remove possible regressor")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956473002/40001
Message was sent while issue was closed.
Description was changed from ========== Retract GrRenderTarget a bit within SkGpuDevice Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c ========== to ========== Retract GrRenderTarget a bit within SkGpuDevice Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c Committed: https://skia.googlesource.com/skia/+/e576874b162f8c66aa6c2e06cb6bc459ccd8b6f9 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/e576874b162f8c66aa6c2e06cb6bc459ccd8b6f9 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
