Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1992)

Unified Diff: content/common/navigation_params.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed DCHECK_IMPLIES(method == "POST", url.SchemeIs(http or https)). Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index 39162ffe2bd06e52a2694616b60de3cf43042307..5089dc9a83415bd95a0d0f5bf01e012e25bd5f39 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -4,10 +4,13 @@
#include "content/common/navigation_params.h"
+#include "base/logging.h"
#include "build/build_config.h"
#include "content/common/service_worker/service_worker_types.h"
#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/common/url_constants.h"
+#include "url/gurl.h"
+#include "url/url_constants.h"
namespace content {
@@ -62,7 +65,13 @@ CommonNavigationParams::CommonNavigationParams(
lofi_state(lofi_state),
navigation_start(navigation_start),
method(method),
- post_data(post_data) {}
+ post_data(post_data) {
+ // |method != "POST"| should imply absence of |post_data|.
+ if (method != "POST" && post_data) {
+ NOTREACHED();
+ this->post_data = nullptr;
+ }
+}
CommonNavigationParams::CommonNavigationParams(
const CommonNavigationParams& other) = default;

Powered by Google App Engine
This is Rietveld 408576698