Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: content/browser/loader/resource_request_info_impl.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed DCHECK_IMPLIES(method == "POST", url.SchemeIs(http or https)). Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_request_info_impl.cc
diff --git a/content/browser/loader/resource_request_info_impl.cc b/content/browser/loader/resource_request_info_impl.cc
index 37f4e992fb1541514a0d7585773eb9118e07d50b..0ff3592575ab1efdb3036a402b68b870b71cc813 100644
--- a/content/browser/loader/resource_request_info_impl.cc
+++ b/content/browser/loader/resource_request_info_impl.cc
@@ -61,35 +61,35 @@ void ResourceRequestInfo::AllocateForTesting(net::URLRequest* request,
// the main frame.
DCHECK(resource_type != RESOURCE_TYPE_MAIN_FRAME || is_main_frame);
- ResourceRequestInfoImpl* info =
- new ResourceRequestInfoImpl(
- PROCESS_TYPE_RENDERER, // process_type
- render_process_id, // child_id
- render_view_id, // route_id
- -1, // frame_tree_node_id
- 0, // origin_pid
- 0, // request_id
- render_frame_id, // render_frame_id
- is_main_frame, // is_main_frame
- parent_is_main_frame, // parent_is_main_frame
- resource_type, // resource_type
- ui::PAGE_TRANSITION_LINK, // transition_type
- false, // should_replace_current_entry
- false, // is_download
- false, // is_stream
- allow_download, // allow_download
- false, // has_user_gesture
- false, // enable load timing
- request->has_upload(), // enable upload progress
- false, // do_not_prompt_for_login
- blink::WebReferrerPolicyDefault, // referrer_policy
- blink::WebPageVisibilityStateVisible, // visibility_state
- context, // context
- base::WeakPtr<ResourceMessageFilter>(), // filter
- false, // report_raw_headers
- is_async, // is_async
- is_using_lofi, // is_using_lofi
- std::string()); // original_headers
+ ResourceRequestInfoImpl* info = new ResourceRequestInfoImpl(
+ PROCESS_TYPE_RENDERER, // process_type
+ render_process_id, // child_id
+ render_view_id, // route_id
+ -1, // frame_tree_node_id
+ 0, // origin_pid
+ 0, // request_id
+ render_frame_id, // render_frame_id
+ is_main_frame, // is_main_frame
+ parent_is_main_frame, // parent_is_main_frame
+ resource_type, // resource_type
+ ui::PAGE_TRANSITION_LINK, // transition_type
+ false, // should_replace_current_entry
+ false, // is_download
+ false, // is_stream
+ allow_download, // allow_download
+ false, // has_user_gesture
+ false, // enable load timing
+ request->has_upload(), // enable upload progress
+ false, // do_not_prompt_for_login
+ blink::WebReferrerPolicyDefault, // referrer_policy
+ blink::WebPageVisibilityStateVisible, // visibility_state
+ context, // context
+ base::WeakPtr<ResourceMessageFilter>(), // filter
+ false, // report_raw_headers
+ is_async, // is_async
+ is_using_lofi, // is_using_lofi
+ std::string(), // original_headers
+ nullptr); // body
info->AssociateWithRequest(request);
}
@@ -156,7 +156,8 @@ ResourceRequestInfoImpl::ResourceRequestInfoImpl(
bool report_raw_headers,
bool is_async,
bool is_using_lofi,
- const std::string& original_headers)
+ const std::string& original_headers,
+ const scoped_refptr<ResourceRequestBody> body)
: cross_site_handler_(NULL),
detachable_handler_(NULL),
process_type_(process_type),
@@ -188,8 +189,8 @@ ResourceRequestInfoImpl::ResourceRequestInfoImpl(
report_raw_headers_(report_raw_headers),
is_async_(is_async),
is_using_lofi_(is_using_lofi),
- original_headers_(original_headers) {
-}
+ original_headers_(original_headers),
+ body_(body) {}
ResourceRequestInfoImpl::~ResourceRequestInfoImpl() {
}
@@ -336,4 +337,8 @@ void ResourceRequestInfoImpl::UpdateForTransfer(
filter_ = filter;
}
+void ResourceRequestInfoImpl::ResetBody() {
+ body_ = nullptr;
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698