content/public/browser/navigation_handle.h - Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_handle.h

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed DCHECK_IMPLIES(method == "POST", url.SchemeIs(http or https)). Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/navigation_handle.h

diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h

index 7f1e8ab7111b27370271d709a85602ea5242a041..96b14ef6da138ec6f3241f3cab915ac7f10822ed 100644

--- a/content/public/browser/navigation_handle.h

+++ b/content/public/browser/navigation_handle.h

@@ -89,8 +89,13 @@ class CONTENT_EXPORT NavigationHandle {

// This corresponds to NavigationThrottle::WillSendRequest. They should not

// be queried before that.

- // Whether the navigation is a POST or a GET. This may change during the

- // navigation when encountering a server redirect.

+ // Whether the navigation is done using HTTP POST method. This may change

+ // during the navigation (e.g. after encountering a server redirect).

Łukasz Anforowicz 2016/06/02 22:07:04 It was misleading (IMO) to say "GET", when in real

+ //

+ // Note: page and frame navigations can only be done using HTTP POST or HTTP

+ // GET methods (and using other, scheme-specific protocols for non-http(s) URI

+ // schemes like data: or file:). Therefore //content public API exposes only

+ // |bool IsPost()| as opposed to |const std::string& GetMethod()| method.

virtual bool IsPost() = 0;

// Returns a sanitized version of the referrer for this request.

« no previous file with comments | « content/common/navigation_params.cc ('k') | testing/buildbot/filters/site-per-process.content_browsertests.filter » ('j') | no next file with comments »