content/browser/frame_host/render_frame_proxy_host.cc - Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed DCHECK_IMPLIES(method == "POST", url.SchemeIs(http or https)). Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/render_frame_proxy_host.cc

diff --git a/content/browser/frame_host/render_frame_proxy_host.cc b/content/browser/frame_host/render_frame_proxy_host.cc

index 3c39bf10f40fc3ba67b9f7111dfa869c4c1295a0..9f7a80ce0ee0df946ecb231e1dbc849361b68ed7 100644

--- a/content/browser/frame_host/render_frame_proxy_host.cc

+++ b/content/browser/frame_host/render_frame_proxy_host.cc

@@ -260,10 +260,11 @@ void RenderFrameProxyHost::OnOpenURL(

// TODO(alexmos, creis): Figure out whether |params.user_gesture| needs to be

// passed in as well.

+ // TODO(lukasza): https://crbug.com/344348: Pass real method and post_data.

frame_tree_node_->navigator()->RequestTransferURL(

current_rfh, validated_url, site_instance_.get(), std::vector<GURL>(),

params.referrer, ui::PAGE_TRANSITION_LINK, GlobalRequestID(),

- params.should_replace_current_entry);

+ params.should_replace_current_entry, "GET", nullptr);

}

void RenderFrameProxyHost::OnRouteMessageEvent(

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/loader/DEPS » ('j') | content/public/browser/navigation_handle.h » ('J')