content/browser/frame_host/render_frame_host_manager.cc - Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed DCHECK_IMPLIES(method == "POST", url.SchemeIs(http or https)). Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_proxy_host.cc » ('j') | content/public/browser/navigation_handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index 11c980f40af64da7c37d2ef0438a27ee4d4c578b..3e7cbe11ca6bf9114ed2f3e894e93a830f9c56ec 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -487,9 +487,12 @@ void RenderFrameHostManager::OnCrossSiteResponse(

transferring_render_frame_host->frame_tree_node()

->navigator()

- ->RequestTransferURL(transferring_render_frame_host, transfer_url,

- nullptr, rest_of_chain, referrer, page_transition,

- global_request_id, should_replace_current_entry);

+ ->RequestTransferURL(

+ transferring_render_frame_host, transfer_url, nullptr, rest_of_chain,

+ referrer, page_transition, global_request_id,

+ should_replace_current_entry,

+ transfer_navigation_handle_->IsPost() ? "POST" : "GET",

+ transfer_navigation_handle_->resource_request_body());

// The transferring request was only needed during the RequestTransferURL

// call, so it is safe to clear at this point.