Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1610)

Issue 195623002: roll clang 198389:202554 (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
hans, tfarina
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Visibility:
Public.

Description

roll clang 198389:202554 This change contains several big changes, many of the caused by upstream llvm enabling c++11 in their codebase and thus having higher minimum requirements for their toolchain and runtime environment: * clang on OS X now requires libc++, which means it'll only run on OS X 10.7+, so change the deployment target from 10.5 to 10.7 (we were planning on requiring 10.8 or 10.9, see bug 335325, but since several people are waiting on a new clang, let's go to 10.7 only for now and do more as a follow-up) * On OS X, the compiler is only usable with libc++ if libc++ is checked out and `make install` is run, so do that for the phase 1 compiler. (Chrome doesn't use libc++ yet, so we don't do that for the bootstrapped compiler.) * clang on linux now needs libstdc++ 4.7+ which isn't present on precise. So we now include a newer libstdc++ in the compiler bundle (meaning this clang should still run on precise). * clang is broken for android at r202554. To unblock oilpan, merge three later changes into this roll, llvm r202793, r203601, and r203635 Regular, less tricky clang roll stuff: * Disable the new warning -Wabsolute-value for now (crbug.com/351479 for turning it on) * Disable -Wno-tautological-pointer-compare for libxml where it now fires. * Since this bundles a new version of the oilpan plugin, bump its suffix to _3 * Change plugin code to track upstream api change * Remove plugin flag check-url-directory as that's now always on Due to the c++11 stuff, it's likely that this change will get reverted a few times. BUG=351479, 287029, 341352, 333968, 335325 TBR=hans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257618

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : libc++ #

Patch Set 4 : plugin #

Patch Set 5 : xmlwarn #

Patch Set 6 : abs #

Patch Set 7 : wnoabs #

Patch Set 8 : . #

Patch Set 9 : fix bootstrap #

Patch Set 10 : linux install, and package #

Patch Set 11 : stlport #

Patch Set 12 : patches #

Patch Set 13 : pipe #

Patch Set 14 : . #

Patch Set 15 : ilb #

Patch Set 16 : patch in r202793 too #

Patch Set 17 : fixref #

Patch Set 18 : ehabi #

Patch Set 19 : rebase #

Patch Set 20 : rebase #

Patch Set 21 : cros #

Total comments: 1

Patch Set 22 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -23 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +7 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libxml/libxml.gyp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/plugins/ChromeClassTester.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M tools/clang/scripts/package.sh View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M tools/clang/scripts/plugin_flags.sh View 1 chunk +1 line, -3 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +687 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-18 00:44:57 UTC) #1
Nico
nacl roll went in at r257490
6 years, 9 months ago (2014-03-18 00:45:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/195623002/370001
6 years, 9 months ago (2014-03-18 00:48:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 01:18:44 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=55841
6 years, 9 months ago (2014-03-18 01:18:45 UTC) #5
Nico
Committed patchset #21 manually as r257618 (tree was closed).
6 years, 9 months ago (2014-03-18 10:53:29 UTC) #6
tfarina
6 years, 9 months ago (2014-03-18 13:36:40 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/195623002/diff/370001/tools/clang/scripts/plu...
File tools/clang/scripts/plugin_flags.sh (left):

https://codereview.chromium.org/195623002/diff/370001/tools/clang/scripts/plu...
tools/clang/scripts/plugin_flags.sh:22: -Xclang check-url-directory
So I added it in - https://codereview.chromium.org/183763018, removed from
tools/clang/plugins in - https://codereview.chromium.org/185543003, and when you
roll you remove from plugin_flags.sh.

OK, I'm understanding this process better.

Powered by Google App Engine
This is Rietveld 408576698