Remove check_url_directory flag from clang plugin.

Remove check_url_directory flag from clang plugin.

This is now always on.

BUG=287029
TEST=url_unittets builds under clang plugin without warnings/errors.
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256191

[tfarina, 2014-03-02 23:50:36]

Nico, am I doing this right?

The check was added here -> https://codereview.chromium.org/14064011

Thanks!

[Nico, 2014-03-03 02:26:14]

On 2014/03/02 23:50:36, tfarina wrote:
> Nico, am I doing this right?

Don't you want to check in the diff in the CL description first?

> 
> The check was added here -> https://codereview.chromium.org/14064011
> 
> Thanks!

[tfarina, 2014-03-03 02:29:00]

On 2014/03/03 02:26:14, Nico (vacation Feb 24 - 29) wrote:
> On 2014/03/02 23:50:36, tfarina wrote:
> > Nico, am I doing this right?
> 
> Don't you want to check in the diff in the CL description first?
> 
Check where? In the tree or here manually?

If you meanto check it in the chromium tree, care to say why it is needed? As
far as I know I already fixed the clang issues. Am I missing some step?

[tfarina, 2014-03-03 03:27:23]

So looks like one of the steps is to add check_url_directory to plugin_flags.sh.

https://codereview.chromium.org/10960007

But I never landed a change to add it to plugin_flags.sh, I always hacked
locally.

Do want me to land the diff first so?

[Nico, 2014-03-03 03:35:18]

On Sun, Mar 2, 2014 at 6:29 PM, <tfarina@chromium.org> wrote:

> On 2014/03/03 02:26:14, Nico (vacation Feb 24 - 29) wrote:
>
>> On 2014/03/02 23:50:36, tfarina wrote:
>> > Nico, am I doing this right?
>>
>
>  Don't you want to check in the diff in the CL description first?
>>
>
> Check where? In the tree or here manually?
>

"check in", not "check" :-) Checking in usually refers to the tree.


> If you meanto check it in the chromium tree, care to say why it is needed?
> As
> far as I know I already fixed the clang issues. Am I missing some step?
>

To make sure that this actually works on all bots, and to make sure it
stays working. Say you don't check in the change to plugin_flags.sh but do
land this change here, and then someone breaks building with checking //url
before the next clang roll -- now the clang roll is blocked on getting
//url building with checks again.

We want to be able to roll clang (and plugins) mostly independent of checks
done by a plugin.


>
>
>
> https://codereview.chromium.org/185543003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-03-03 05:08:55]

On 2014/03/03 03:35:18, Nico (vacation Feb 24 - 29) wrote:
> On Sun, Mar 2, 2014 at 6:29 PM, <mailto:tfarina@chromium.org> wrote:
> 
> > On 2014/03/03 02:26:14, Nico (vacation Feb 24 - 29) wrote:
> >
> >> On 2014/03/02 23:50:36, tfarina wrote:
> >> > Nico, am I doing this right?
> >>
> >
> >  Don't you want to check in the diff in the CL description first?
> >>
> >
> > Check where? In the tree or here manually?
> >
> 
> "check in", not "check" :-) Checking in usually refers to the tree.
> 
Yeah, "land" in the repo ;)

I mixed the two meanings. It is easy to make those confusions when translating
to my language, specially at this time of the night :/

> 
> > If you meanto check it in the chromium tree, care to say why it is needed?
> > As
> > far as I know I already fixed the clang issues. Am I missing some step?
> >
> 
> To make sure that this actually works on all bots, and to make sure it
> stays working. Say you don't check in the change to plugin_flags.sh but do
> land this change here, and then someone breaks building with checking //url
> before the next clang roll -- now the clang roll is blocked on getting
> //url building with checks again.
> 
> We want to be able to roll clang (and plugins) mostly independent of checks
> done by a plugin.
>
Thanks for making sure I was doing the right thing and for guiding me toward the
right path!

Cheers!

[tfarina, 2014-03-10 17:30:56]

Nico, can we land this now?

[Nico, 2014-03-10 17:34:06]

Yes, but please change the CL description to say "this is now always on" instead
of the diff.

[Nico, 2014-03-10 17:34:55]

lgtm with new cl description. (Hans, we'll have to change plugin-flags to no
longer pass this with the next clang roll)

[hans, 2014-03-10 18:32:36]

On 2014/03/10 17:34:55, Nico wrote:
> lgtm with new cl description. (Hans, we'll have to change plugin-flags to no
> longer pass this with the next clang roll)

Cool. I suppose the plugin will error if we forget that, so this works as an
automatic reminder?

[Nico, 2014-03-10 18:34:29]

I think so.


On Mon, Mar 10, 2014 at 11:32 AM, <hans@chromium.org> wrote:

> On 2014/03/10 17:34:55, Nico wrote:
>
>> lgtm with new cl description. (Hans, we'll have to change plugin-flags to
>> no
>> longer pass this with the next clang roll)
>>
>
> Cool. I suppose the plugin will error if we forget that, so this works as
> an
> automatic reminder?
>
> https://codereview.chromium.org/185543003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-03-10 22:17:23]

Nico, could you copy me in this next clang roll? (I would like to learn about
and see how it is).

Thanks,

[tfarina, 2014-03-10 22:17:36]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-03-10 23:04:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/185543003/1

[commit-bot: I haz the power, 2014-03-10 23:57:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/185543003/1

[commit-bot: I haz the power, 2014-03-11 11:07:42]

Change committed as 256191