Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 183763018: Turn on clang plugin checks for //url directory. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Turn on clang plugin checks for //url directory. Once this sticks, the check can be removed entirely. BUG=287029 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/clang/scripts/plugin_flags.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
6 years, 9 months ago (2014-03-03 03:50:01 UTC) #1
Nico
lgtm
6 years, 9 months ago (2014-03-03 04:08:30 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-03 04:26:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/183763018/1
6 years, 9 months ago (2014-03-03 04:27:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 07:54:46 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=272895
6 years, 9 months ago (2014-03-03 07:54:46 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-03 13:51:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/183763018/1
6 years, 9 months ago (2014-03-03 13:51:32 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 14:51:10 UTC) #9
Message was sent while issue was closed.
Change committed as 254463

Powered by Google App Engine
This is Rietveld 408576698