Issue 19560003: [v8-dev] ARM: Make double registers low/high safe

Issue 19560003: [v8-dev] ARM: Make double registers low/high safe (Closed)

Created:
7 years, 5 months ago by m.m.capewell

Modified:
7 years, 5 months ago

Reviewers:
ulan, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: Make double registers low/high safe This patch prevents taking the low/high part of a double-precision VFP register that has no corresponding single-precision VFP registers. BUG=none TEST=Added to test-disasm-arm.cc, test-assembler-arm.cc Committed: https://code.google.com/p/v8/source/detail?r=15885

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+260 lines, -146 lines)			Patch
M	src/arm/assembler-arm.h	View	5 chunks	+62 lines, -32 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View	2 chunks	+19 lines, -2 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/arm/disasm-arm.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/ic-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-arm.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	21 chunks	+44 lines, -54 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	9 chunks	+18 lines, -12 lines	2 comments	Download
M	src/arm/macro-assembler-arm.cc	View	16 chunks	+72 lines, -30 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-assembler-arm.cc	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	test/cctest/test-disasm-arm.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM. https://codereview.chromium.org/19560003/diff/1/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): https://codereview.chromium.org/19560003/diff/1/src/arm/macro-assembler-arm.h#newcode881 src/arm/macro-assembler-arm.h:881: LowDwVfpRegister double_scratch0, double_scratch would be more consistent with ...

7 years, 5 months ago (2013-07-25 11:49:54 UTC) #2

m.m.capewell

7 years, 5 months ago (2013-07-25 15:04:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15885 (presubmit successful).

Expand Messages | Collapse Messages