Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1955993004:
Fix PRESUBMIT.py erros on uploading DEPS change. (Closed)
|
Created:
4 years, 7 months ago by tandrii(chromium) Modified:
4 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix PRESUBMIT.py erros on uploading DEPS change.
Depends on depot_tools change https://codereview.chromium.org/1955223002,
so if you think this broke you, please update depot_tools by just running
gclient with no arguments.
R=machenbach@chromium.org
BUG=609832
nOTRY=true
Committed: https://crrev.com/ed3b7e17bdcb3ec8ee0655db7227461476c1f9c8
Cr-Commit-Position: refs/heads/master@{#393243}
Patch Set 1 #
Total comments: 1
Patch Set 2 : nit #Messages
Total messages: 32 (16 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955993004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
https://codereview.chromium.org/1955993004/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1955993004/diff/1/PRESUBMIT.py#newcode1069 PRESUBMIT.py:1069: owner_email, reviewers = input_api.canned_checks.GetCodereviewOwnerAndReviewers( nit: 82 chars...
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955993004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/1955993004/#ps20001 (title: "nit")
The CQ bit was unchecked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955993004/20001
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955993004/20001
The CQ bit was unchecked by tandrii@chromium.org
Description was changed from ========== Fix PRESUBMIT.py erros on uploading DEPS change. Depends on depot_tools change https://codereview.chromium.org/1955223002, so if you think this broke you, please update depot_tools by just running gclient with no arguments. R=machenbach@chromium.org BUG=609832 ========== to ========== Fix PRESUBMIT.py erros on uploading DEPS change. Depends on depot_tools change https://codereview.chromium.org/1955223002, so if you think this broke you, please update depot_tools by just running gclient with no arguments. R=machenbach@chromium.org BUG=609832 nOTRY=true ==========
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955993004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tandrii@chromium.org changed reviewers: + phajdan.jr@chromium.org
+Pawel as owner
LGTM
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955993004/20001
Message was sent while issue was closed.
Description was changed from ========== Fix PRESUBMIT.py erros on uploading DEPS change. Depends on depot_tools change https://codereview.chromium.org/1955223002, so if you think this broke you, please update depot_tools by just running gclient with no arguments. R=machenbach@chromium.org BUG=609832 nOTRY=true ========== to ========== Fix PRESUBMIT.py erros on uploading DEPS change. Depends on depot_tools change https://codereview.chromium.org/1955223002, so if you think this broke you, please update depot_tools by just running gclient with no arguments. R=machenbach@chromium.org BUG=609832 nOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix PRESUBMIT.py erros on uploading DEPS change. Depends on depot_tools change https://codereview.chromium.org/1955223002, so if you think this broke you, please update depot_tools by just running gclient with no arguments. R=machenbach@chromium.org BUG=609832 nOTRY=true ========== to ========== Fix PRESUBMIT.py erros on uploading DEPS change. Depends on depot_tools change https://codereview.chromium.org/1955223002, so if you think this broke you, please update depot_tools by just running gclient with no arguments. R=machenbach@chromium.org BUG=609832 nOTRY=true Committed: https://crrev.com/ed3b7e17bdcb3ec8ee0655db7227461476c1f9c8 Cr-Commit-Position: refs/heads/master@{#393243} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ed3b7e17bdcb3ec8ee0655db7227461476c1f9c8 Cr-Commit-Position: refs/heads/master@{#393243} |
