Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1955223002: Properly expose already used elsewhere functionality. (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly expose already used elsewhere functionality. Also make _RietveldOwnerAndReviewers have same semantics as before, to resolve immediate bug until chromium checkouts of developers are updated. BUG=609832 R=machenbach@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M presubmit_canned_checks.py View 4 chunks +11 lines, -19 lines 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tandrii(chromium)
4 years, 7 months ago (2016-05-07 04:59:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955223002/1
4 years, 7 months ago (2016-05-07 04:59:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-07 05:01:47 UTC) #5
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-08 07:57:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955223002/1
4 years, 7 months ago (2016-05-09 06:24:00 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 06:26:36 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300494

Powered by Google App Engine
This is Rietveld 408576698