PRESUBMIT.py - Issue 1955993004: Fix PRESUBMIT.py erros on uploading DEPS change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1955993004: Fix PRESUBMIT.py erros on uploading DEPS change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 874734e4977c739df019f2d33496260820e4724d..b5e7fede3961018788d0bef1c5d7870b31e34cd4 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1066,10 +1066,11 @@ def _CheckAddedDepsHaveTargetApprovals(input_api, output_api):

output = output_api.PresubmitNotifyResult

owners_db = input_api.owners_db

- owner_email, reviewers = input_api.canned_checks._RietveldOwnerAndReviewers(

- input_api,

- owners_db.email_regexp,

- approval_needed=input_api.is_committing)

+ owner_email, reviewers = (

+ input_api.canned_checks.GetCodereviewOwnerAndReviewers(

+ input_api,

+ owners_db.email_regexp,

+ approval_needed=input_api.is_committing))

owner_email = owner_email or input_api.change.author_email

« no previous file with comments | « no previous file | no next file » | no next file with comments »