Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19543005: turn off debugging printfs (Closed)

Created:
7 years, 5 months ago by caryclark
Modified:
7 years, 5 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

turn off debugging printfs fix pathops issues 1417, 1418 be more rigorous about pulling intersections of lines to end points rewrite cubic/line and quad/line intersections to share style BUG= Committed: https://code.google.com/p/skia/source/detail?r=10270

Patch Set 1 #

Total comments: 1

Patch Set 2 : path ops work in progress coincidence #

Patch Set 3 : fix cubic self intersect #

Patch Set 4 : remove unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+949 lines, -795 lines) Patch
M src/pathops/SkDCubicIntersection.cpp View 1 2 3 8 chunks +135 lines, -83 lines 0 comments Download
M src/pathops/SkDCubicLineIntersection.cpp View 1 chunk +187 lines, -185 lines 0 comments Download
M src/pathops/SkDLineIntersection.cpp View 2 chunks +11 lines, -6 lines 0 comments Download
M src/pathops/SkDQuadIntersection.cpp View 1 2 12 chunks +77 lines, -36 lines 0 comments Download
M src/pathops/SkDQuadLineIntersection.cpp View 10 chunks +69 lines, -57 lines 0 comments Download
M src/pathops/SkIntersections.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/pathops/SkIntersections.cpp View 1 2 3 1 chunk +0 lines, -102 lines 0 comments Download
M src/pathops/SkOpSegment.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 6 chunks +38 lines, -8 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsCubic.h View 2 chunks +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCurve.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsLine.h View 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsLine.cpp View 1 2 3 2 chunks +8 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsQuad.h View 2 chunks +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsRect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 1 chunk +13 lines, -8 lines 0 comments Download
M src/pathops/SkPathOpsTypes.cpp View 1 2 chunks +25 lines, -12 lines 0 comments Download
M tests/PathOpsAngleTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 2 8 chunks +90 lines, -64 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/PathOpsCubicQuadIntersectionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PathOpsDLineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsLineIntersectionTest.cpp View 6 chunks +13 lines, -8 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 chunks +173 lines, -138 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 1 8 chunks +48 lines, -35 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionThreadedTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fmalita_google_do_not_use
https://codereview.chromium.org/19543005/diff/1/src/pathops/SkOpSegment.cpp File src/pathops/SkOpSegment.cpp (right): https://codereview.chromium.org/19543005/diff/1/src/pathops/SkOpSegment.cpp#newcode3010 src/pathops/SkOpSegment.cpp:3010: #if SK_DEBUG When building Chrome, I had to change ...
7 years, 5 months ago (2013-07-18 18:31:28 UTC) #1
caryclark
7 years, 5 months ago (2013-07-23 15:28:16 UTC) #2
Message was sent while issue was closed. 
Committed patchset #4 manually as r10270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698