Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 1953823005: Only use white list on indefinite checks (Closed)

Created:
4 years, 7 months ago by Leaf
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M lib/runtime/dart_sdk.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/codegen/lib/typed_data/typed_data_list_test.dart View 1 2 6 chunks +31 lines, -23 lines 0 comments Download
M tool/input_sdk/lib/async/async_error.dart View 1 1 chunk +14 lines, -4 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
Currently, we ignore casts between any two types in the white list (e.g. List<int> to ...
4 years, 7 months ago (2016-05-06 20:04:19 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-06 20:29:10 UTC) #3
Leaf
4 years, 7 months ago (2016-05-07 02:14:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3f24c709218de43aaad2b0175ea1c83b3c3dddda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698