Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: lib/runtime/dart_sdk.js

Issue 1953823005: Only use white list on indefinite checks (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | test/codegen/lib/typed_data/typed_data_list_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_sdk.js
diff --git a/lib/runtime/dart_sdk.js b/lib/runtime/dart_sdk.js
index dae1fed52c88a2b50ab1476f2fe3a8dc78b38d55..7bebddbe1f53ac6ef51e643b016676f83af01784 100644
--- a/lib/runtime/dart_sdk.js
+++ b/lib/runtime/dart_sdk.js
@@ -531,6 +531,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
let actual = dart.getReifiedType(obj);
let result = dart.isSubtype(actual, type);
if (result || actual == dart.jsobject || actual == core.int && type == core.double) return true;
+ if (result === false) return false;
if (ignoreFromWhiteList == void 0) return result;
if (dart._ignoreTypeFailure(actual, type)) return true;
return result;
@@ -13395,9 +13396,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
async._registerErrorHandler = function(R) {
return (errorHandler, zone) => {
if (dart.is(errorHandler, async.ZoneBinaryCallback)) {
- return zone.registerBinaryCallback(R, dart.dynamic, core.StackTrace)(dart.as(errorHandler, async.ZoneBinaryCallback$(R, dart.dynamic, core.StackTrace)));
+ return zone.registerBinaryCallback(dart.dynamic, dart.dynamic, core.StackTrace)(dart.as(errorHandler, async.ZoneBinaryCallback$(dart.dynamic, dart.dynamic, core.StackTrace)));
} else {
- return zone.registerUnaryCallback(R, dart.dynamic)(dart.as(errorHandler, async.ZoneUnaryCallback$(R, dart.dynamic)));
+ return zone.registerUnaryCallback(dart.dynamic, dart.dynamic)(dart.as(errorHandler, async.ZoneUnaryCallback));
}
};
};
« no previous file with comments | « no previous file | test/codegen/lib/typed_data/typed_data_list_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698