Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tool/input_sdk/private/ddc_runtime/operations.dart

Issue 1953823005: Only use white list on indefinite checks (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/input_sdk/lib/async/async_error.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/ddc_runtime/operations.dart
diff --git a/tool/input_sdk/private/ddc_runtime/operations.dart b/tool/input_sdk/private/ddc_runtime/operations.dart
index 3ec38119608e5a59a3b5f3b22a6111fe2b4d51b3..97359b68e263c0fb5b73c9a93407d39f31b294e6 100644
--- a/tool/input_sdk/private/ddc_runtime/operations.dart
+++ b/tool/input_sdk/private/ddc_runtime/operations.dart
@@ -204,6 +204,7 @@ strongInstanceOf(obj, type, ignoreFromWhiteList) => JS('', '''(() => {
let result = $isSubtype(actual, $type);
if (result || actual == $jsobject ||
actual == $int && type == $double) return true;
+ if (result === false) return false;
if ($ignoreFromWhiteList == void 0) return result;
if ($_ignoreTypeFailure(actual, $type)) return true;
return result;
« no previous file with comments | « tool/input_sdk/lib/async/async_error.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698