Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1953463002: Empty webkitpy/common/net/buildbot/__init__.py and update imports. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Empty webkitpy/common/net/buildbot/__init__.py and update imports. BUG=598897 Committed: https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519 Cr-Commit-Position: refs/heads/master@{#392265}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove the net/buildbot/ subdirectory; move the files into net/ and fix pylint warnings #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -938 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/host.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py View 1 2 chunks +3 lines, -3 lines 1 comment Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py View 1 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py View 1 1 chunk +0 lines, -405 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_mock.py View 1 1 chunk +0 lines, -93 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py View 1 1 chunk +0 lines, -426 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
qyearsley
Note: One possible refactoring here would be to remove the common/net/buildbot/ subdirectory and move its ...
4 years, 7 months ago (2016-05-04 17:27:47 UTC) #2
Dirk Pranke
lgtm. https://codereview.chromium.org/1953463002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py File third_party/WebKit/Tools/Scripts/webkitpy/common/host.py (right): https://codereview.chromium.org/1953463002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py#newcode36 third_party/WebKit/Tools/Scripts/webkitpy/common/host.py:36: from webkitpy.common.net.buildbot.buildbot import BuildBot we should move the ...
4 years, 7 months ago (2016-05-05 23:51:44 UTC) #3
qyearsley
https://codereview.chromium.org/1953463002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py File third_party/WebKit/Tools/Scripts/webkitpy/common/host.py (right): https://codereview.chromium.org/1953463002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py#newcode36 third_party/WebKit/Tools/Scripts/webkitpy/common/host.py:36: from webkitpy.common.net.buildbot.buildbot import BuildBot On 2016/05/05 at 23:51:44, Dirk ...
4 years, 7 months ago (2016-05-06 17:31:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953463002/20001
4 years, 7 months ago (2016-05-06 18:50:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 19:54:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953463002/20001
4 years, 7 months ago (2016-05-07 18:16:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-07 18:23:21 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 18:24:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519
Cr-Commit-Position: refs/heads/master@{#392265}

Powered by Google App Engine
This is Rietveld 408576698