third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py - Issue 1953463002: Empty webkitpy/common/net/buildbot/__init__.py and update imports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

Issue 1953463002: Empty webkitpy/common/net/buildbot/__init__.py and update imports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove the net/buildbot/ subdirectory; move the files into net/ and fix pylint warnings Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

similarity index 98%

rename from third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py

rename to third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

index 9b90ea6ac12771db6d86fc54a358b7727ad60804..d7e84a51eacceec971d9882684321550a86cb271 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

@@ -136,8 +136,8 @@ class Builder(object):

# FIXME: This method is horribly slow due to the huge network load.

# FIXME: This is a poor way to do revision -> build mapping.

# Better would be to ask buildbot through some sort of API.

- print "Loading revision/build list from %s." % self.results_url()

- print "This may take a while..."

+ _log.info("Loading revision/build list from %s." % self.results_url())

+ _log.info("This may take a while...")

qyearsley 2016/05/06 17:31:23 The style check in the presubmit gave warnings abo

result_files = self._buildbot._fetch_twisted_directory_listing(self.results_url())

except urllib2.HTTPError, error:

if error.code != 404:

@@ -376,7 +376,7 @@ class BuildBot(object):

for builder in builder_revisions:

for revision, succeeded in builder_revisions[builder]:

revision_statuses.setdefault(revision, set())

- if succeeded and revision_statuses[revision] != None:

+ if succeeded and revision_statuses[revision] is not None:

revision_statuses[revision].add(builder)

else:

revision_statuses[revision] = None