Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/host.py

Issue 1953463002: Empty webkitpy/common/net/buildbot/__init__.py and update imports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 Google Inc. All rights reserved. 1 # Copyright (c) 2010 Google Inc. All rights reserved.
2 # Copyright (c) 2009 Apple Inc. All rights reserved. 2 # Copyright (c) 2009 Apple Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 29
30 import logging 30 import logging
31 import os 31 import os
32 import sys 32 import sys
33 33
34 from webkitpy.common.checkout.scm.detection import SCMDetector 34 from webkitpy.common.checkout.scm.detection import SCMDetector
35 from webkitpy.common.memoized import memoized 35 from webkitpy.common.memoized import memoized
36 from webkitpy.common.net import buildbot, web 36 from webkitpy.common.net.buildbot.buildbot import BuildBot
Dirk Pranke 2016/05/05 23:51:44 we should move the buildbot files up into net and
qyearsley 2016/05/06 17:31:23 Done.
37 from webkitpy.common.net import web
37 from webkitpy.common.system.systemhost import SystemHost 38 from webkitpy.common.system.systemhost import SystemHost
38 from webkitpy.layout_tests.port.factory import PortFactory 39 from webkitpy.layout_tests.port.factory import PortFactory
39 40
40 41
41 _log = logging.getLogger(__name__) 42 _log = logging.getLogger(__name__)
42 43
43 44
44 class Host(SystemHost): 45 class Host(SystemHost):
45 46
46 def __init__(self): 47 def __init__(self):
47 SystemHost.__init__(self) 48 SystemHost.__init__(self)
48 self.web = web.Web() 49 self.web = web.Web()
49 50
50 self._scm = None 51 self._scm = None
51 52
52 # Everything below this line is WebKit-specific and belongs on a higher- level object. 53 # Everything below this line is WebKit-specific and belongs on a higher- level object.
53 self.buildbot = buildbot.BuildBot() 54 self.buildbot = BuildBot()
54 55
55 # FIXME: Unfortunately Port objects are currently the central-dispatch o bjects of the NRWT world. 56 # FIXME: Unfortunately Port objects are currently the central-dispatch o bjects of the NRWT world.
56 # In order to instantiate a port correctly, we have to pass it at least an executive, user, scm, and filesystem 57 # In order to instantiate a port correctly, we have to pass it at least an executive, user, scm, and filesystem
57 # so for now we just pass along the whole Host object. 58 # so for now we just pass along the whole Host object.
58 # FIXME: PortFactory doesn't belong on this Host object if Port is going to have a Host (circular dependency). 59 # FIXME: PortFactory doesn't belong on this Host object if Port is going to have a Host (circular dependency).
59 self.port_factory = PortFactory(self) 60 self.port_factory = PortFactory(self)
60 61
61 self._engage_awesome_locale_hacks() 62 self._engage_awesome_locale_hacks()
62 63
63 # We call this from the Host constructor, as it's one of the 64 # We call this from the Host constructor, as it's one of the
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 109
109 def scm(self): 110 def scm(self):
110 return self._scm 111 return self._scm
111 112
112 def scm_for_path(self, path): 113 def scm_for_path(self, path):
113 # FIXME: make scm() be a wrapper around this, and clean up the way 114 # FIXME: make scm() be a wrapper around this, and clean up the way
114 # callers call initialize_scm() (to remove patch_directories) and scm(). 115 # callers call initialize_scm() (to remove patch_directories) and scm().
115 if sys.platform == "win32": 116 if sys.platform == "win32":
116 self._engage_awesome_windows_hacks() 117 self._engage_awesome_windows_hacks()
117 return SCMDetector(self.filesystem, self.executive).detect_scm_system(pa th) 118 return SCMDetector(self.filesystem, self.executive).detect_scm_system(pa th)
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698