Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2469)

Issue 1953413002: Deprecate URL.createObjectURL/revokeObjectURL in Service Workers (Closed)

Created:
4 years, 7 months ago by jsbell
Modified:
4 years, 7 months ago
Reviewers:
Mark P, Rick Byers
CC:
chromium-reviews, philipj_slow, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, sof, eae+blinkwatch, tommyw+watchlist_chromium.org, eric.carlson_apple.com, haraken, blink-reviews-dom_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Deprecate URL.createObjectURL/revokeObjectURL in Service Workers As a prelude to removal of these methods, slip a deprecation warning in. Intent Thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoeyBwAJ BUG=604951 R=rbyers@chromium.org,mpearson@chromium.org Review-Url: https://codereview.chromium.org/1938183002 Cr-Commit-Position: refs/heads/master@{#391951} (cherry picked from commit 0ac96023be4cd86fec7404752ea61c7d6ede5ab0) Committed: https://chromium.googlesource.com/chromium/src/+/364169fce92dc76d0e96b2c0970237cad179eb96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/DOMURL.cpp View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jsbell
Committed patchset #1 (id:1) manually as 364169fce92dc76d0e96b2c0970237cad179eb96.
4 years, 7 months ago (2016-05-06 23:51:45 UTC) #2
Mark P
histograms.xml lgtm
4 years, 7 months ago (2016-05-06 23:59:28 UTC) #3
Rick Byers
4 years, 7 months ago (2016-05-10 01:30:21 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698